Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

自動リリースworkflowを追加 #3

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

y-chan
Copy link

@y-chan y-chan commented Jul 15, 2024

close #1

srcをパッケージングしたけど、これpyproject.tomlとか含める必要ない...?

サンプルはここ: https://github.com/y-chan/python-template/releases/tag/0.0.2

@y-chan y-chan linked an issue Jul 15, 2024 that may be closed by this pull request
4 tasks
Copy link
Member

@sushichan044 sushichan044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

骨子は問題ないと思います!

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
sushichan044

This comment was marked as duplicate.

@sushichan044
Copy link
Member

sushichan044 commented Jul 15, 2024

#2 でghalintの警告を直します

@sushichan044
Copy link
Member

pyproject.tomlを含めるかどうかは確認がいりそうなのでしておきます

y-chan and others added 2 commits July 16, 2024 02:03
Co-authored-by: Kentaro Suzuki <[email protected]>
@sushichan044
Copy link
Member

sushichan044 commented Jul 15, 2024

メモ
pyproject.tomlのversionを手動で変更してはいけないことをREADMEに書く
別のPRでも良さそう

=> #4 でやります

Copy link
Member

@sushichan044 sushichan044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@sushichan044
Copy link
Member

よく考えたらsrcごと配布するより(cd src && zip -r hoge.zip .)みたいな風に配布した方が
zipファイル解凍したときに余分なディレクトリができなくて良い気がしている

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

自動リリース用Workflowの整備
2 participants